Use crate:: prefix for root macro suggestions
#141132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
rustbot
added
S-waiting-on-review
fmease
reviewed
May 17, 2025
fmease
reviewed
May 17, 2025
fmease
approved these changes
May 17, 2025
|
Eh, my 'concern' is negligible. Thanks! :) @bors r+ rollup |
bors
added
S-waiting-on-bors
|
I agree with these suggestions and will:
|
|
Ok :) |
bors
added
S-waiting-on-author
fmease
reviewed
May 17, 2025
|
Thanks :) |
bors
added
S-waiting-on-bors
jieyouxu
reviewed
May 17, 2025
There was a problem hiding this comment.
Suggestion: while you're modifying this test, can you please rename it to sth more meaningful? We can still keep a backlink to the issue in a doc comment.
Actually nvm, this is in the queue already. I can do that as a follow-up.
fmease
added a commit
to fmease/rust
that referenced
this pull request
May 18, 2025
Use `crate::` prefix for root macro suggestions Fixes rust-lang#141082 I've changed the prefix to `crate` directly, since it's compatible across all editions.
fmease
added a commit
to fmease/rust
that referenced
this pull request
May 18, 2025
Use `crate::` prefix for root macro suggestions Fixes rust-lang#141082 I've changed the prefix to `crate` directly, since it's compatible across all editions.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 18, 2025
Rollup of 7 pull requests Successful merges: - rust-lang#140113 (Add per page TOC in the `rustc` book) - rust-lang#140490 (split `asm!` parsing and validation) - rust-lang#140924 (Make some `f32`/`f64` tests also run in const-context) - rust-lang#141045 ([win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test) - rust-lang#141071 (Enable [behind-upstream] triagebot option for rust-lang/rust) - rust-lang#141132 (Use `crate::` prefix for root macro suggestions) - rust-lang#141139 (Fix Rust for Linux ping group label) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 18, 2025
Rollup of 8 pull requests Successful merges: - rust-lang#140113 (Add per page TOC in the `rustc` book) - rust-lang#140511 (Stabilize `#![feature(non_null_from_ref)]`) - rust-lang#140924 (Make some `f32`/`f64` tests also run in const-context) - rust-lang#140966 (Remove #![feature(let_chains)] from library and src/librustdoc) - rust-lang#141045 ([win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test) - rust-lang#141071 (Enable [behind-upstream] triagebot option for rust-lang/rust) - rust-lang#141132 (Use `crate::` prefix for root macro suggestions) - rust-lang#141139 (Fix Rust for Linux ping group label) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 18, 2025
Rollup merge of rust-lang#141132 - bvanjoi:issue-141082, r=fmease Use `crate::` prefix for root macro suggestions Fixes rust-lang#141082 I've changed the prefix to `crate` directly, since it's compatible across all editions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141082
I've changed the prefix to
cratedirectly, since it's compatible across all editions.